move namedpipe connector to separate #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyamnamboodiripad
approved these changes
Nov 20, 2023
jonsequitur
reviewed
Nov 20, 2023
| @@ -47,6 +47,7 @@ try { | |||
| "Microsoft.DotNet.Interactive.Journey", | |||
| "Microsoft.DotNet.Interactive.Kql", | |||
| "Microsoft.DotNet.Interactive.Mermaid", | |||
| "Microsoft.DotNet.Interactive.NamedPipe", | |||
There was a problem hiding this comment.
Suggested change
| "Microsoft.DotNet.Interactive.NamedPipe", | |
| "Microsoft.DotNet.Interactive.NamedPipeConnector", |
colombod
force-pushed
the
split_namepipe_connector
branch
from
cef2db7
to
0ad592e
Compare
remove it from tool project add notebook rename
colombod
force-pushed
the
split_namepipe_connector
branch
from
0ad592e
to
bf34d20
Compare
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net7.0</TargetFramework> |
There was a problem hiding this comment.
This probably should be net7.0-windows
Suggested change
| <TargetFramework>net7.0</TargetFramework> | |
| <TargetFramework>net7.0-windows</TargetFramework> |
CA1416
colombod
force-pushed
the
split_namepipe_connector
branch
from
37cc8f9
to
dcab606
Compare
jonsequitur
reviewed
Nov 20, 2023
| using Xunit.Abstractions; | ||
|
|
||
| namespace Microsoft.DotNet.Interactive.Tests; | ||
| namespace Microsoft.DotNet.Interactive.NamedPipeConnectorConnector.Tests; |
There was a problem hiding this comment.
Suggested change
| namespace Microsoft.DotNet.Interactive.NamedPipeConnectorConnector.Tests; | |
| namespace Microsoft.DotNet.Interactive.NamedPipeConnector.Tests; |
jonsequitur
reviewed
Nov 20, 2023
|
|
||
| namespace Microsoft.DotNet.Interactive.Connection; | ||
| namespace Microsoft.DotNet.Interactive.NamedPipeConnectorConnector; |
There was a problem hiding this comment.
Suggested change
| namespace Microsoft.DotNet.Interactive.NamedPipeConnectorConnector; | |
| namespace Microsoft.DotNet.Interactive.NamedPipeConnector; |
jonsequitur
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.