return false on command and restrict cursor position >= 0 #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes a bug that caused crashes in dotnet-repl. I used the NuGet pkgs containing the bug fixes in a test build of dotnet-repl, changing API consumption as necessary to correct errors introduced by the interface changes between the current state of main and the current build referenced by the project, and the crashes were remedied. |
colombod
approved these changes
Oct 19, 2023
|
I merged but I noticed no test has been added. Can you add the test case or describe the repro? |
|
@colombod created new pr with the testing and made another change to catch both conditionals that would decrement position below 0 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.