Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable declaration addition #3152

Merged
merged 11 commits into from
Aug 31, 2023
Merged

Variable declaration addition #3152

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
61a3a1f
Variable declaration progress
bleaphar Aug 22, 2023
bb47039
Working variable declarations
bleaphar Aug 23, 2023
1055539
Partial save
bleaphar Aug 24, 2023
41bf349
Changes for variable declaration
bleaphar Aug 25, 2023
2ca6c18
Removal and changes for pr
bleaphar Aug 25, 2023
554d098
Condition for variable declaration node
bleaphar Aug 25, 2023
044768f
Merge branch 'main' into main
bleaphar Aug 25, 2023
c9c5f7c
Addition of diagnostic test
bleaphar Aug 25, 2023
fe437dc
fix warning
jonsequitur Aug 26, 2023
83e731d
intermediate changes
bleaphar Aug 30, 2023
e4e3a6c
Fix for combinatorial tests
bleaphar Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Microsoft.DotNet.Interactive.HttpRequestParser/HttpVariableDeclarationNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ public override IEnumerable<Diagnostic> GetDiagnostics()
yield return diagnostic;
}

yield return base.CreateDiagnostic("Variable name expected.");
if (string.IsNullOrWhiteSpace(VariableName))
jonsequitur marked this conversation as resolved.
Show resolved Hide resolved
{
yield return CreateDiagnostic("Variable name expected.");
}
}
}