Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment variable culture from Visual Studio/VSCode to command line processes #3054

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

ocallesp
Copy link
Contributor

@ocallesp ocallesp commented Jun 22, 2023

This pull request aims to propagate the Culture and UICulture settings from Visual Studio and VS Code to the child processes responsible for executing the code (kernels).

Three new unit tests:

  • Culture_Is_Set_Based_On_Environment_Variable
  • UICulture_Is_Set_Based_On_Environment_Variable
  • Kernel_Execute_Code_Using_Culture_From_Parent_Thread_That_Created_It

@ocallesp ocallesp force-pushed the set-culture-in-command-line branch 2 times, most recently from 674904a to 9fbb843 Compare June 27, 2023 19:17
@ocallesp ocallesp marked this pull request as ready for review June 27, 2023 22:46
@ocallesp ocallesp enabled auto-merge June 28, 2023 20:44
@ocallesp ocallesp merged commit 69a9616 into dotnet:main Jun 28, 2023
@ocallesp ocallesp deleted the set-culture-in-command-line branch June 28, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants