-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass environment variable culture from Visual Studio/VSCode to command line processes #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocallesp
force-pushed
the
set-culture-in-command-line
branch
2 times, most recently
from
June 27, 2023 19:17
674904a
to
9fbb843
Compare
jonsequitur
reviewed
Jun 27, 2023
jonsequitur
reviewed
Jun 27, 2023
ocallesp
force-pushed
the
set-culture-in-command-line
branch
from
June 28, 2023 15:37
9fbb843
to
2df0c33
Compare
jonsequitur
reviewed
Jun 28, 2023
jonsequitur
reviewed
Jun 28, 2023
jonsequitur
approved these changes
Jun 28, 2023
shyamnamboodiripad
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to propagate the Culture and UICulture settings from Visual Studio and VS Code to the child processes responsible for executing the code (kernels).
Three new unit tests: