Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear problem window for closed notebooks #2968

Merged
merged 1 commit into from
May 4, 2023
Merged

clear problem window for closed notebooks #2968

merged 1 commit into from
May 4, 2023

Conversation

colombod
Copy link
Member

@colombod colombod commented May 4, 2023 •
edited
Loading

new document
image
error
image
after closing
image

@colombod colombod linked an issue May 4, 2023 that may be closed by this pull request
Polyglot Notebook: [DevExE2E] If unsaved and closing the .dib file, the execution errors still show in PROBLEMS page. #2946
Closed
15 tasks
@colombod colombod added the bug Something isn't working label May 4, 2023
@colombod colombod merged commit 1b2795b into dotnet:main May 4, 2023
@colombod colombod deleted the clear_diagnostics branch May 4, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamnamboodiripad shyamnamboodiripad shyamnamboodiripad approved these changes

@brettfo brettfo Awaiting requested review from brettfo

@jonsequitur jonsequitur Awaiting requested review from jonsequitur

@AbhitejJohn AbhitejJohn Awaiting requested review from AbhitejJohn

Assignees
No one assigned
Labels
Area-Polyglot Notebooks Extension bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@colombod @shyamnamboodiripad