Fix usage of ExecutionContext in netstandard2.0 #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text.Run API. This is required to make the API work correctly when running against .NET Framework.
…perations BlockingCollection after _schedulerDisposalSource.Cancel() is called. Also dispose _schedulerDisposalSource.
colombod
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always pass a copy of the captured
ExecutionContextto theExecutionContext.RunAPI. Without this, executing this code atopnet472results in the error mentioned in Trying to host ProxyKernel within a .NET Framework assembly results in an InvalidOperationException #2775. It seems like the .NET Framework version of this API requires that the sameExecutionContextinstance should not be passed toExecutionContext.Runmore than once. See this note in the documentation under theThe following is applicable to .NET Framework onlysection.Also fixes a
NullReferenceExceptionthat is encountered during theKernelScheduler's disposal if cancellation is triggered after the blocking collection is disposed. This exception is not encountered if we switch the order of execution to trigger cancellation before the blocking collection is disposed.