CSS handling multiline code #2650
Conversation
colombod
added
Area-Formatting
| @@ -73,7 +73,7 @@ private static async Task<string> GetInputAsync(string prompt, bool isPassword, | |||
| public static void CSS(string content) => | |||
| // From https://stackoverflow.com/questions/524696/how-to-create-a-style-tag-with-javascript | |||
| Javascript($@" | |||
| var css = '{content}', | |||
| var css = `{content}`, | |||
There was a problem hiding this comment.
I was considering removing this method altogether, along with the Javascript method. People should likely be emitting HTML elements for this or calling a JavaScript kernel if one is available.
There was a problem hiding this comment.
this is blocking some notebooks development as that is public api. I'd fix it and mark as deprecated?
There was a problem hiding this comment.
but I think is very convenient shortcut to be able to sue the CSS helper to add styles
There was a problem hiding this comment.
Convenient isn't sufficient if it doesn't work consistently.
There was a problem hiding this comment.
I'd suggest we leave it for now, with the fix, but should discuss whether this is the right design, especially given the Pythonesque top-level function name.
fixes #2649