Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw more informative exception if tools service process exits before a connection is established. #2648

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

corivera
Copy link
Member

When StreamJsonRpc throws a ConnectionLostException, it isn't immediately obvious what the underlying issue is. This change adds an extra wrapping exception if the process exited abruptly before a connection was established, since in that case we probably won't be able to get any logs from the tools service exiting so close to startup. I tried to grab the standard output the tools service produces in that scenario, but it looks like it already gets pulled off the stream as part of the RPC client reading off incoming messages. Enabling tracing for the RPC client also didn't reveal what that incoming message was, so this is the best I can do without getting into some weird middleman stream to capture incoming messages from the tools service.

@jonsequitur jonsequitur merged commit 9df30fa into dotnet:main Jan 26, 2023
@corivera corivera deleted the startupLogging branch January 27, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants