apply the appropriate language configuration as the selected cell changes #2592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the comment/uncomment keyboard shortcuts
Ctrl
+K
,C
/Ctrl
+K
,U
to work based on the language of the current cell. This also allows things like auto-complete to fill in)
after a(
is typed, etc.This doesn't work, however, if the cursor is after a kernel selector magic command like this:
If the user tries to comment the
print(..)
line it'll be replaced by// print(...)
instead of# print(...)
because we have no way of detecting the cursor's location, and thus the current language at the cursor. If we did it would be trivial to see that we were in a#!python
selector and to the right thing, but since polyglot cells aren't as common, this is a shortcoming we'll have to deal with.Fixes #2559.