handle the case kernelinfo si deserialised as dicittionary #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Dec 27, 2022
| } | ||
|
|
||
| // todo: the kernelInfo should not deserialize as a dictionary | ||
| if (kernelInfoObj is Dictionary<string,object> kernelInfoAsDictionary) |
There was a problem hiding this comment.
Is there a test for the issue this is intended to resolve?
There was a problem hiding this comment.
Just added a test that uses serialize and parse request. Serialize touches the new code. The document used in test comes from a vscode serialize request.
colombod
force-pushed
the
metadata_update
branch
from
b1383ca
to
fe9faca
Compare
jonsequitur
approved these changes
Dec 27, 2022
colombod
commented
Dec 27, 2022
| [Fact] | ||
| public void Notebook_parser_server_can_handle_serialize_requests() | ||
| { | ||
| var request = @"{ |
There was a problem hiding this comment.
@jonsequitur this request is taken from vscode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From vscode invocation the document is deserialized and the medatadata now is a dictionary. This fixes saving notebooks