[WIP - discussion] - Alternate Method of Seq.map chaining #2 #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease. 2. remove a couple of reference tests that were flaky on many platforms due to a dependence on specific VS installation options. 3. Update a test that was relient on an installation of .Net 2.0
A generalized version, with a bit more flexible composition, of dotnet#1528.
|
Sorry all, looks like my git skills are letting me down again. I tried to pick an earlier spot to go from, as I'm having problems with nuget and VisualCppTools, but looks like the file list is just bad... Anyway, the files changed seems to be correct... |
|
I've reworked this, and going to branch from a cleaner spot. So killing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liboz in #1528 introduced a method of chaining consecutive map statements, this is a bit more general approach which allows combining both filter and map, hopefully making it a bit more useful.
It could be extended to a range of other functions as well, as well as potentially more efficent generators (i.e. indexing through an array etc.)
Anway, feel like I'm bombing the PRs, without finishing off things. Sorry about that. But if you think any of them are actually wanted, then nag me for that one, and then I'll have more inspiration to complete it.