Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 823 - Compiler failing with ArgumentException when calling data constructor with equality operator #1318

Merged
merged 4 commits into from
Jul 21, 2016
Merged

Fix 823 - Compiler failing with ArgumentException when calling data constructor with equality operator #1318

merged 4 commits into from
Jul 21, 2016

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jul 4, 2016

@dsyme
Copy link
Contributor Author

dsyme commented Jul 4, 2016

This is ready to go in

@vladima
Copy link
Contributor

vladima commented Jul 4, 2016

👍

@dsyme dsyme changed the title Fix 823 Fix 823 - Compiler failing with ArgumentException when calling data constructor with equality operator Jul 5, 2016
@dsyme
Copy link
Contributor Author

dsyme commented Jul 17, 2016

Transient AppVeyor failure (unrelated to PR):

[00:32:21] 1) Failed : FSharp-Tests-Core+Members+Incremental.incremental(FSI_FILE)
[00:32:21] Error running command 'C:\projects\visualfsharp-3dtit\tests\..\release\net40\bin\fsiAnyCPU.exe' with args ' -r:System.Core.dll --nowarn:20 --define:INTERACTIVE --maxerrors:1 --abortonerror test.fsx' in directory 'C:\projects\visualfsharp-3dtit\tests\fsharp\core\members\incremental'. ERRORLEVEL -1073740771 ERRORLEVEL -1073740771
[00:32:21] at NUnitConf.checkTestResult(Result`2 result) in C:\projects\visualfsharp-3dtit\tests\fsharp\nunitConf.fs:line 14

@dsyme dsyme merged commit 29440cf into dotnet:master Jul 21, 2016
@manofstick manofstick mentioned this pull request Oct 14, 2016
Closed
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsyme @vladima @msftclas