-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need external dependencies to support .NET Standard in order to remove the requirement for imports in project.json #5176
Comments
Hi what is the supposed workaround? |
Use "imports" in project.json. "frameworks": {
"netcoreapp1.0": {
"imports": "portable-net451+win8"
}
} |
Hi, still getting EntityFramework.Core 7.0.0-rc1-final is not compatible with .NETPlatform,Version=v5.0. |
@stannynuytkens can you provide more details? That looks you have a bad |
{ |
Just trying to add EntityFramework.Core to a 4.6.1 Portable class library for use in a .net core app. |
Full output: Restoring packages for 'BitBite.Data'. |
Yea, the |
Hi David, yeah that's about exactly what I'm trying to do. =) |
First thing you need to do is install update 2 and change the portable class library to a .NET Standard class library by right clicking and using the project properties. Also make sure you have the latest version of the NuGet client |
Thank you David, will do. EDIT: that works but I can't add a reference to my data library from the dotnetcore project. |
@stannynuytkens this conversation has deviated from the original issue. Can you open a new issue on http://github.com/aspnet/home? |
We have an unofficial build of Ix-Async here that has netstandard support. Work is in progress to make it official. |
@onovotny good news.
I assume this is why the assemblies aren't strong-named yet? |
Bingo. We could do an OSS sign but the Rx.NET repo only has the public keys checked in. There are two things we need -- the full SNK and Authenticode. The Authenticode signing will be moving to the .NET Foundation, not sure how this affects the strong name, or are those separate? |
@onovotny IIUC strong name and authenticode are separate. e.g. EF nightly builds on myget.org/gallery/aspnetcidev have been built with strong-named signing but haven't been code-signed yet. Side note: I'm testing the builds on http://myget.org/gallery/rxnet. Where should I file issues? Do you have a fork? |
Fix dotnet#2192. Partial fix to dotnet#5176
Fix dotnet#2192. Partial fix to dotnet#5176
Fix dotnet#2192. Partial fix to dotnet#5176
Fix dotnet#2192. Partial fix to dotnet#5176
Merged #5689, which means using EF Core 1.0 won't require "imports" in .NET Core apps. Thanks to @MichaelKetting @shiftkey @onovotny @bartdesmet for their work to update Ix-Async and Re-linq to support .NET Standard. |
Quick question -- where are you currently pulling the Ix bits from? FWIW, the latest version on the myget feed is OSS signed with the SNK and has the granular dependencies applied. |
@onovotny we mirrored System.Interactive.Async to our CI build feeds for now. http://myget.org/feed/aspnetcidev/package/nuget/System.Interactive.Async. When the updated version lands on NuGet.org, we will use that instead. |
So this is closed, but a project.json containing only dnxcore are still not compatible with EntityFrameworkCore.MicrosoftSqlServer? I still need this workaround:
When will this workaround go away? |
@wpostma |
What's odd then is that the VS IDE still picks up and suggests adding "EntityFrameworkCore.MicrosoftSqlServer" to my project.json when it can't find references to things like DbContext. |
@wpostma I am not sure how the suggestion mechanism works internally but I ran an experiment in my machine and it seems to remember packages that you have used in previous VS sessions. So I think this may be a good time to remove pre-RTM packages from other projects, local NuGet cache, etc. |
Two of EF Core's dependencies, Remotion.Linq and Ix-Async currently use pre-existing portable targets to support multiple platforms. Until these packages add support for .NET Standard, libraries or applications using EF Core will need to specify additional import attributes in project.json.
These two issues track the necessary changes in our dependencies:
dotnet/reactive#174
https://www.re-motion.org/jira/browse/RMLNQ-98
Cc: @natemcmaster @rowanmiller
The text was updated successfully, but these errors were encountered: