Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileStream.Handle is obsolete in .NET6 too. #7455

Closed
Tracked by #64596
iwkjosec opened this issue Dec 4, 2021 · 8 comments
Closed
Tracked by #64596

FileStream.Handle is obsolete in .NET6 too. #7455

iwkjosec opened this issue Dec 4, 2021 · 8 comments
Labels
area-System.IO Pri3 Indicates issues/PRs that are low priority

Comments

@iwkjosec
Copy link

iwkjosec commented Dec 4, 2021

FileStream.Handle Property > Applies to
image

@PRMerger4 PRMerger4 added the Pri3 Indicates issues/PRs that are low priority label Dec 4, 2021
@ghost
Copy link

ghost commented Dec 4, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

FileStream.Handle Property > Applies to
image

Author: iwkjosec
Assignees: -
Labels:

Pri3, area-System.IO, :watch: Not Triaged

Milestone: -

@carlossanlop
Copy link
Member

Hello @iwkjosec - .NET 6 shows in the list, it's the first item, so I'm not sure what is being reported here. Can you please clarify?

@svick
Copy link
Contributor

svick commented Dec 5, 2021

@carlossanlop The "Versions (Obsolete)" heading indicates that the property is obsolete in versions in italics and parentheses, but .Net 6 is not one of those.

My guess is that this is related to the XML source for the page, which looks like this (simplified):

<Attribute FrameworkAlternate="net-5.0;netcore-3.0;netcore-3.1;netstandard-2.1">
    <AttributeName Language="C#">[System.Obsolete("This property has been deprecated.  Please use FileStream's SafeFileHandle property instead.  https://go.microsoft.com/fwlink/?linkid=14202")]</AttributeName>
</Attribute>
<Attribute FrameworkAlternate="net-6.0">
    <AttributeName Language="C#">[System.Obsolete("FileStream.Handle has been deprecated. Use FileStream's SafeFileHandle property instead.")]</AttributeName>
</Attribute>
<Attribute FrameworkAlternate="netcore-2.0;netcore-2.1;netcore-2.2;netframework-2.0;netframework-3.0;netframework-3.5;netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8;netstandard-2.0">
    <AttributeName Language="C#">[System.Obsolete("This property has been deprecated.  Please use FileStream's SafeFileHandle property instead.  http://go.microsoft.com/fwlink/?linkid=14202")]</AttributeName>
</Attribute>
<Attribute FrameworkAlternate="xamarinandroid-7.1;xamarinios-10.8;xamarinmac-3.0">
    <AttributeName Language="C#">[System.Obsolete("Use SafeFileHandle instead")]</AttributeName>
</Attribute>

Notice that the property is obsolete in many frameworks, but only those in the first group are marked that way in the Applies to section.

@carlossanlop
Copy link
Member

Ah thanks for clarifying this, @svick.

@gewarren @mimisasouvanh this looks like a bug in the way mdoc groups the obsolete frameworks.

.NET 6 should be grouped with the others, not separate.

@svick
Copy link
Contributor

svick commented Dec 5, 2021

@carlossanlop I think it's because .Net 6 has a different description for the Obsolete attribute (see dotnet/runtime#56690). I'm not sure why .Net Core 2.0 and others are also listed separately.

@gewarren
Copy link
Contributor

gewarren commented Dec 6, 2021

.netcore-2.0 and the others are listed separately because the info link is http:// instead of https://.

@gewarren
Copy link
Contributor

gewarren commented Dec 6, 2021

I logged internal issue https://dev.azure.com/ceapex/Engineering/_workitems/edit/528676 and assigned to Mimi.

@jeffhandley jeffhandley added untriaged New issue has not been triaged by the area owner and removed ⌚ Not Triaged labels May 2, 2022
@jozkee
Copy link
Member

jozkee commented May 3, 2022

This is fixed now, I can see all .NET (core) versions in italics and paretheses. Thanks @mimisasouvanh @gewarren.

@jozkee jozkee closed this as completed May 3, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 3, 2022
@jozkee jozkee added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO Pri3 Indicates issues/PRs that are low priority
Projects
None yet
Development

No branches or pull requests

8 participants