Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/// <inheritdoc /> #3699

Closed
richardschneider opened this issue Nov 29, 2018 · 18 comments
Closed

/// <inheritdoc /> #3699

richardschneider opened this issue Nov 29, 2018 · 18 comments
Labels
dotnet: xml-comment XML comment for .NET API reference docs dotnet Generate .NET API reference docs
Milestone

Comments

@richardschneider
Copy link
Contributor

DocFX Version Used:
docfx 2.36.1.0

Template used: (default or statictoc or contain custom template)
default

Steps to Reproduce:

  1. git clone https://github.com/richardschneider/net-ipfs-api.git
  2. docfx doc\docfx.json

Expected Behavior:

The documentation for Block should inherit the documentation from IDataBlock interface.

Actual Behavior:

No documentation is inherited.

Other:

The docfx.json is fairly standard. It uses a xref to get the IDataBlock documentation.

Here's the links to the generated documentation for Block and IDataBlock and the source code for Block.cs and IDataBlock.cs.

@superyyrrzz
Copy link
Contributor

I find you are referencing IDataBlock through xref. If so, <inheritdoc /> will not work in this case. It requires IDataBlock to be built together with Block to work. You can see the xrefmap.yml doesn't contain IDataBlock's summary, so that DocFX cannot get this information in this case.

@richardschneider
Copy link
Contributor Author

Are you saying that it is not possible to use <inheritdoc /> on another assembly?

Could you explain how I can get this to work. How can I tell DocFX to get the summary for IDataBlock?

IDataBlock is defined in the Ipfs.Core nuget package, which ships with .xml documentation file .

@superyyrrzz
Copy link
Contributor

This is not supported now. <inheritdoc /> is a feature contributed from community with only basic support (#1178). This should be an improve to look into XML file for summary.

@stale
Copy link

stale bot commented Mar 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Mar 6, 2019
@superyyrrzz superyyrrzz removed the stale label Mar 6, 2019
@superyyrrzz superyyrrzz added the dotnet: xml-comment XML comment for .NET API reference docs label May 14, 2019
@rymeskar
Copy link

Hi @superyyrrzz ,
I noticed that recently you had been grouping some of the issues regarding xmldoc comments into a specific area.

Could you please share whether we could expect extended support of inheritdoc (including cref and other more granular features)? We are right now considering whether to make some workarounds around this in our code? (mostly revolving around copy-pasting :( )

@superyyrrzz
Copy link
Contributor

Hi @rymeskar , I am grouping them as there are too many issues under label Area-Metadata.

Regarding inheritdoc, it is a syntax from Sandcastle. DocFX does not guarantee to support all Sandcastle syntax, but we are open to community contribution for these.

@rymeskar
Copy link

rymeskar commented May 15, 2019

@superyyrrzz Thank you for the explanation. It does make sense having in mind the official VS/Roslyn state of inheritdoc is 'unsupported'.

On the other hand, I would like to let you know that there is quite a lively discussion around Roslyn/VS to add the inheritdoc support natively.

@superyyrrzz superyyrrzz added Area-SandcastleParity and removed dotnet: xml-comment XML comment for .NET API reference docs labels Aug 13, 2019
@dotMorten
Copy link
Contributor

dotMorten commented Oct 10, 2019

Regarding inheritdoc, it is a syntax from Sandcastle

Not any more. It's now becoming a 1st class feature in Visual Studio's Intellisense as well:
https://www.youtube.com/watch?v=mg2aocZA9Pc&feature=youtu.be&t=1540

@glennawatson
Copy link

It is a first class citizen as of Visual Studio 16.4.

@muhmuhhum
Copy link

muhmuhhum commented Nov 4, 2020

Are there any updates regarding <inheritdoc> support in docfx ?

@dotMorten
Copy link
Contributor

This is a big of a showstopper for us. Any update here?

@yevgeni-zolotko
Copy link

Any updates on this one?

@alexhelms
Copy link

It has been a few months, any update on this?

@dougclutter
Copy link

This is something our Team uses too. Any plans to add support for inheritdoc?

@yufeih yufeih added dotnet Generate .NET API reference docs dotnet: xml-comment XML comment for .NET API reference docs and removed Area-SandcastleParity labels Dec 15, 2022
@Crauzer
Copy link

Crauzer commented Dec 29, 2022

Would be great to have support for this

@dougclutter
Copy link

Any updates on this? Thanks!

@yufeih yufeih added this to the Backlog milestone Jan 12, 2023
@yufeih yufeih modified the milestones: Backlog, Working Set Feb 15, 2023
@dougclutter
Copy link

Thanks for implementing this! In what release number will it be available?

@yufeih
Copy link
Contributor

yufeih commented Apr 7, 2023

It is available in v2.65.0 released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet: xml-comment XML comment for .NET API reference docs dotnet Generate .NET API reference docs
Projects
None yet
Development

No branches or pull requests