Skip to content
This repository has been archived by the owner on Jul 7, 2024. It is now read-only.

Progress? #19

Closed
Wraith2 opened this issue Mar 6, 2023 · 26 comments
Closed

Progress? #19

Wraith2 opened this issue Mar 6, 2023 · 26 comments

Comments

@Wraith2
Copy link

Wraith2 commented Mar 6, 2023

It was mentioned on an EF livestream that progress was being made but the only commit is from 2021. Is there code being worked on? If so can we see it in case we can help out?

@roji
Copy link
Member

roji commented Mar 6, 2023

@Wraith2 there's definitely been progress, and we're also discussing internally about future directions for this. We'll communicate on this soon, hang tight.

@Wraith2
Copy link
Author

Wraith2 commented Apr 17, 2023

How soon?

@roji
Copy link
Member

roji commented Apr 17, 2023

We'll very likely post an update in the next few weeks.

@ilmax
Copy link

ilmax commented Apr 18, 2023

Just out of curiosity, why is this being worked on behind closed doors at the moment?

@LeftTwixWand
Copy link

From what I see: Woodstar been added as one of the goals of EF Core 8:
dotnet/efcore#29853

@ymotton
Copy link

ymotton commented Jun 18, 2023

Just out of curiosity, why is this being worked on behind closed doors at the moment?

Bump ^

Would love to see this opened up to the community.
If we've learned anything from the last couple of years, performance work gets a lot of outside eyeballs and contributions.
Please, let us help.

@Wraith2
Copy link
Author

Wraith2 commented Jul 5, 2023

We'll communicate on this soon, hang tight.

It's 4 months later. Can you define "soon" for me?

@ilmax
Copy link

ilmax commented Jul 6, 2023

We'll very likely post an update in the next few weeks.

Also few now has a whole different meaning to me 😄

@roji
Copy link
Member

roji commented Jul 17, 2023

Everyone, we're now heads-down in the last phases of .NET/EF 8.0 feature work, before the window for improvements closes. I hoped to be able to do this much earlier, but unfortunately there have been many unscheduled things that required our attention.

We'll post an update once the release goes into stabilization and things calm down a bit.

@Tornhoof
Copy link

@roji as rc1 ist out now, what about a tiny update?

@Wraith2
Copy link
Author

Wraith2 commented Oct 5, 2023

Given that EF 8 is now in stabilization mode, per dotnet/efcore#29853 (comment) can we get some information what's going on please? Even if we don't get code can we get some sort of information about what's happened and what is yet to happen?

@roji
Copy link
Member

roji commented Oct 6, 2023

@Wraith2 unfortunately I'm still extremely busy with 8.0-related work, and that's unlikely to change before the release in November. We've done some investigation and prototype coding in 8.0, but a serious write-up is needed to describe that, and I simply don't have the time to do that at the moment.

I'm sorry things are taking this long, but it is what it is. I promise that once I get some breathing space I'll prioritize summarizing what we've done and the state of affairs.

@PureKrome
Copy link

Keep up the awesome work @roji (and team). We respect what you're doing 🤗

@Varorbc
Copy link

Varorbc commented Nov 30, 2023

@roji any update ?

@roji
Copy link
Member

roji commented Nov 30, 2023

Not yet.

@jernejk
Copy link

jernejk commented Dec 4, 2023

@roji, apologies for the probe but is the adapter going to be ready by February?

I'm doing a talk about EF Core + SQL Server; a deeper dive and at least having information on differences would be greatly appreciated. Especially, if the "async" issue will be fixed when needing to download multiple MBs from SQL Server to .NET.

The plan is to show less-known features of EF Core and SQL Server, as well as how to make them work well together, as there is very little material on this.

@Wraith2
Copy link
Author

Wraith2 commented Dec 5, 2023

specially, if the "async" issue will be fixed when needing to download multiple MBs from SQL Server to .NET.

You may want to know about dotnet/SqlClient#2164 which should be in the next full release.

@jernejk
Copy link

jernejk commented Dec 5, 2023

Thank you, @Wraith2! :)

I checked this GB issue weeks ago, and then I tried with the Preview 3 version of the adapter and EF Core 8 RC2.
My demo currently uses Microsoft.Data.SqlClient 5.2.0-preview3.23201.1 and EF Core 8.0.0 but I'll return to this once preview 4 is out. :) (or try to set it up locally if I get too bored on Xmas)

I still would appreciate it if there are any more in-depth differences between SqlServer.Core and Microsoft.Data.SqlClient that I could mention at my talk to get people excited for its release. :)

@mburbea
Copy link

mburbea commented Feb 7, 2024

It's been a few months since the last poke, but any updates @roji?

@Wraith2
Copy link
Author

Wraith2 commented Jun 12, 2024

anything?

@vonzshik
Copy link

anything?

Something's going on with SqlClient (dotnet/SqlClient#2570) ...

@edwardneal
Copy link

We're starting to see PRs for SqlClientX merged, so I'd definitely be interested to understand what the roadmap for this is and what design work's already been done.

@Wraith2
Copy link
Author

Wraith2 commented Jun 28, 2024

There is a discussion about SqlClientX here dotnet/SqlClient#2603 which I encourage everyone to read through and ask questions in.
There is also an in depth discussion about connection pooling and how the new implementation is going to work here dotnet/SqlClient#2612

It looks like any innovation is going to happen in SqlClient by having a secondary set of code in the library written by the SqlClient and SqlServer teams rather than being implemented externally in woodstar. This all smells like internal MS politics to me but whatever is going on we'll probably never understand the reasons.

@ajcvickers
Copy link
Member

@Wraith2 If I have any credit built up with the community over the years, then let me use some to just say what is happening in SqlClient is good. Of course, politics are involved, but fundamentally there is enthusiasm and investment in making SQL connectivity in .NET better. This is good! Celebrate! 🥳 🍾 🎆

@ErikEJ
Copy link

ErikEJ commented Jul 1, 2024

@ajcvickers We owe each other beers! 😄

@roji
Copy link
Member

roji commented Jul 1, 2024

Please see #22 for a short summary of the Woodstar experiment.

@roji roji closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests