This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Test and optimise TypeEqual and TypeIs behaviour for pointer types. #16150
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSadov
reviewed
Feb 18, 2017
| @@ -61,7 +61,7 @@ private static AnalyzeTypeIsResult AnalyzeTypeIs(Expression operand, Type testTy | |||
| return testType == typeof(void) ? AnalyzeTypeIsResult.KnownTrue : AnalyzeTypeIsResult.KnownFalse; | |||
| } | |||
|
|
|||
| if (testType == typeof(void)) | |||
| if (testType == typeof(void) || testType.GetTypeInfo().IsPointer) | |||
There was a problem hiding this comment.
Can it be just testType.IsPointer?
There was a problem hiding this comment.
Yeah, it can be. I'll update soon.
|
LGTM, but wonder if we still need to do |
Contributes to #8081, but since the current behaviour is to safely always return false, continue to allow pointer type operands. There is already code that examines these expressions for always-false or always-true behaviour, so have pointer types also result in the always-false path being taken.
JonHanna
force-pushed
the
pointer_types_type_equal_is
branch
from
6ecab5f
to
7f887e9
Compare
|
Updated. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…pe_equal_is Test and optimise TypeEqual and TypeIs behaviour for pointer types. Commit migrated from dotnet/corefx@11c6841
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #8081, but since the current behaviour is to safely always return false, continue to allow pointer type operands.
There is already code that examines these expressions for always-false or always-true behaviour, so have pointer types also result in the always-false path being taken.