-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Port AMSI scanning for assembly loads #23231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check on the style for predefines, the rest lgtm.
@dotnet-bot help |
Welcome to the dotnet/coreclr Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember also to revert the whitespace changes before submitting. That made the diff a little difficult to review.
@GrabYourPitchforks I'll leave the decision on whether to keep/remove the whitespace changes to @elinor-fung, but here's a GitHub tip for future reference: you can add |
Updated for nicer predefine (added I haven't reverted the whitespace changes (but I did set my editor to not trim trailing whitespace anymore). If it is really a big problem, I can go through and revert them tomorrow. |
I think that's fine. |
It's not a huge deal to be honest. It just makes reviewing / isolating the change a bit difficult because of additional noise. But it's really just a minor complaint in the grand scheme of things. |
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test |
Thanks so much @elinor-fung for getting to this! Much appreciated. :) |
* Port AMSI scanning for assembly loads * Define PLATFORM_WINDOWS for Windows build * Remove check for LOAD_LIBRARY_SEARCH_SYSTEM32 support Commit migrated from dotnet/coreclr@3a02976
Pass all assemblies loaded from byte arrays to AmsiScanBuffer on Windows.
Port from .NET Framework 4.8
Fixes #21370