Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PkgProj permit no VersionSuffix being set #6305

Closed
ericstj opened this issue Oct 1, 2020 · 3 comments
Closed

Make PkgProj permit no VersionSuffix being set #6305

ericstj opened this issue Oct 1, 2020 · 3 comments
Labels
area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc

Comments

@ericstj
Copy link
Member

ericstj commented Oct 1, 2020

We should fix the dotnet/runtime packaging infra to not require VersionSuffix. See https://github.com/dotnet/runtime/pull/42872/files#r497644103

We ought to permit an unset VersionSuffix and error any place where we would have needed one to be set (EG: a stable package referencing non-stable package).

@ericstj
Copy link
Member Author

ericstj commented Oct 1, 2020

cc @ViktorHofer @Anipik

@AraHaan
Copy link
Member

AraHaan commented Dec 20, 2021

Are you refering to this part of the code in arcade?

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L119-L141

If so, I want to change this to where it won't override what the user sets in their eng\Versions.props on their repository if they wanted to manually set the version suffix for some reason after importing the arcade sdk itself.

I was thinking of filing a new issue but then I found this one.

@ericstj
Copy link
Member Author

ericstj commented Jan 4, 2022

No, this was for pkgproj. I don't think we need this issue any more as we are moving off of pkgproj.

@ericstj ericstj closed this as completed Jan 4, 2022
@ericstj ericstj added the area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc
Projects
None yet
Development

No branches or pull requests

2 participants