Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResNet maxpool #719

Closed
githubxiaoa opened this issue Sep 13, 2022 · 2 comments · Fixed by #725
Closed

ResNet maxpool #719

githubxiaoa opened this issue Sep 13, 2022 · 2 comments · Fixed by #725

Comments

@githubxiaoa
Copy link

pytorch code:
self.maxpool = nn.MaxPool2d(kernel_size=3, stride=2, padding=1)

kernel_size=3

torchsharp:
maxpool = MaxPool2d(kernelSize: 2, stride: 2, padding: 1);
@NiklasGustafsson
Copy link
Contributor

@githubxiaoa -- is there a question or error report here? I'm not sure what the issue is from your code examples.

@NiklasGustafsson
Copy link
Contributor

Ah, I see -- the torchvision.ResNet models have a bug. Will be fixed in next version.

@NiklasGustafsson NiklasGustafsson mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ResNet MaxPool2d kernel_size NiklasGustafsson/TorchSharp
2 participants
@NiklasGustafsson @githubxiaoa