Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize torchsharp infrastructure #1346

Open
6 tasks
ericstj opened this issue Jun 27, 2024 · 0 comments
Open
6 tasks

Modernize torchsharp infrastructure #1346

ericstj opened this issue Jun 27, 2024 · 0 comments

Comments

@ericstj
Copy link
Member

ericstj commented Jun 27, 2024

In looking at Torchsharp's build I had a few thoughts for improvement.

  • Evaluate using arcade and provided build templates.
  • Remove as much as possible from the YML and have it be part of the local build scripts so that it's easier to repro things that are hit by the official build.
  • Remove use of the nupkgproj and instead pack from the CProj projects where possible
  • For the remaining nupkgproj have them use the Microsf.Build.NoTargets SDK to avoid C# specific targets.
  • Add all projects to the SLN, and control the pack behavior with IsPackable conditions rather than conditions in a project
    <PackProject Include="**\libtorch-cpu.nupkgproj" Condition="'$(IncludeLibTorchCpuPackages)' == 'true'" />
  • Adopt package readme's following a similar convention to dotnet\runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant