Fix wildcard support for --with-attributes option. #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldvanmanen
force-pushed
the
fix/with-attributes-wildcard-support
branch
from
7b35a59
to
d9d74e9
Compare
|
@dotnet-policy-service agree |
|
@tannergooding How do I request a review? Seems I'm not allowed to request a review for this pull request. |
tannergooding
approved these changes
Sep 27, 2024
|
Sorry for the delay, have been busy locking down the .NET 9 release and this hadn't had all CI legs passing so it didn't bubble up on my radar yet. |
|
No worries! Thanks for getting back to me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the help text the --with-attribute options supports wildcards:.
-wa, --with-attribute <with-attribute>An attribute to be added to the given remapped declaration name during binding generation. Supports wildcards. []However, the method
void WithAttributes(...)invokesTryGetMappedValue(...)withmatchStarset tofalseinstead oftrue. This PR fixes that so that--with-attributes *=<attribute>will add[<attribute>]to all remapped declaration names during binding generation that don't have a more specific mapping (i.e.--with-attribute X=<attribute>will take precedence over--with-attribute *=<attribute>.