@graphql-yoga/render-graphiql: still request to other domain while it is recommended for offline usage

[joshuaavalon]

Describe the bug

In GraphiQL, it is recommended to use @graphql-yoga/render-graphiql for offline usage.

However, the favicon is still requesting to GitHub.

graphql-yoga/packages/render-graphiql/src/index.ts

Lines 11 to 14 in e77c443

	<link
	rel="icon"
	href="https://github.com/raw/dotansimha/graphql-yoga/main/website/public/favicon.ico"
	/>

Your Example Website or App

https://github.com/dotansimha/graphql-yoga/blob/e77c4433aa3e9f19708bd03a41e5adf7ecf6b4f9/packages/render-graphiql/src/index.ts

Steps to Reproduce the Bug or Issue

import { createYoga } from 'graphql-yoga'
import { renderGraphiQL } from '@graphql-yoga/render-graphiql'

const yoga = createYoga({ renderGraphiQL })

Expected behavior

No request to other domains.

Screenshots or Videos

No response

Platform

• OS: Windows
• NodeJS: 18
• @graphql-yoga/render-graphiql version(s): 3.5.1

Additional context

No response

[n1ru4l]

Hey @joshuaavalon! You wanna take care of this? It should be possible to inline it, see https://stackoverflow.com/a/68051929/4202031

[ardatan]

Available in the latest release!