Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] Rename graphiql.defaultQuery to graphiql.defaultDocumentString #2038

Closed
Tracked by #1358
n1ru4l opened this issue Nov 8, 2022 · 3 comments
Closed
Tracked by #1358

[v3] Rename graphiql.defaultQuery to graphiql.defaultDocumentString #2038

n1ru4l opened this issue Nov 8, 2022 · 3 comments
Milestone
v3

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 8, 2022 •
edited
Loading

The term default "query" is misleading IMHO.
The content is actually a GraphQL document string, which can contain query, mutation, and subscription operations.
@n1ru4l n1ru4l added this to the v3 milestone Nov 8, 2022
@saihaj
Copy link
Collaborator

saihaj commented Nov 8, 2022

this comes from graphiql we are just exposing those props
https://github.com/graphql/graphiql/blob/29630c2219bca8b825ab0897840864364a9de2e8/packages/graphiql-react/src/editor/context.tsx#L149-L157

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Nov 8, 2022

@saihaj okay - I still don't like it though 😁

@n1ru4l n1ru4l closed this as completed Nov 8, 2022
@saihaj
Copy link
Collaborator

saihaj commented Nov 8, 2022

@saihaj okay - I still don't like it though 😁

we should file this in graphiql and next major maybe they can consider renaming

@theguild-bot theguild-bot mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@n1ru4l @saihaj