Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtendableEvent.waitUntil API for Service Worker Environments #1538

Closed
Tracked by #1358
n1ru4l opened this issue Aug 4, 2022 · 2 comments
Closed
Tracked by #1358

ExtendableEvent.waitUntil API for Service Worker Environments #1538

n1ru4l opened this issue Aug 4, 2022 · 2 comments
Assignees
Milestone

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Aug 4, 2022

I think we might need handling for the following within Yoga: https://developer.mozilla.org/en-US/docs/Web/API/ExtendableEvent/waitUntil

This is also used in https://developers.cloudflare.com/workers/runtime-apis/fetch-event/#methods
https://github.com/robertcepa/toucan-js/blob/41d9c6b4f20a1acbf6063114aec9124d856f673e/src/index.ts#L217-L234

The idea here is that the response can be returned/sent immediately, without first awaiting for additional task that does not NEED block the response such as error reporting.


Related #1488

@n1ru4l n1ru4l added this to the v3 milestone Aug 4, 2022
@theguild-bot theguild-bot mentioned this issue Aug 9, 2022
@ardatan
Copy link
Collaborator

ardatan commented Aug 24, 2022

This is no longer needed right @n1ru4l ?

@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Aug 24, 2022

It is, I just did not make progress on the sentry plugin

@ardatan ardatan closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants