Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure/Cleanup tests #1526

Closed
Tracked by #1358
n1ru4l opened this issue Aug 2, 2022 · 1 comment
Closed
Tracked by #1358

Restructure/Cleanup tests #1526

n1ru4l opened this issue Aug 2, 2022 · 1 comment
Assignees
@n1ru4l
Milestone
v3

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Aug 2, 2022

  • Separate integration and unit tests
  • make it easy to only run unit tests locally
  • Move all tests that don't require a real HTTP server to "unit" tests
@n1ru4l n1ru4l added this to the v3 milestone Aug 2, 2022
@ardatan
Copy link
Collaborator

ardatan commented Aug 2, 2022

So Node/HTTP tests that test the connection via HTTP should be in @whatwg-node/server (multipart, event stream etc)
Then Yoga tests should only check Response objects.

@n1ru4l n1ru4l self-assigned this Aug 3, 2022
@theguild-bot theguild-bot mentioned this issue Aug 9, 2022
Closed
@n1ru4l n1ru4l mentioned this issue Aug 9, 2022
Merged
@n1ru4l n1ru4l closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n1ru4l n1ru4l

Labels
None yet
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@n1ru4l @ardatan