Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create our own EventSource implementation based on fetch #1390

Closed
Tracked by #1358
n1ru4l opened this issue Jul 13, 2022 · 2 comments
Closed
Tracked by #1358

Create our own EventSource implementation based on fetch #1390

n1ru4l opened this issue Jul 13, 2022 · 2 comments

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jul 13, 2022

EventSource has some issues, including being unable to differentiate between unexpected HTTP connection closing (e.g. due to a flaky internet connection) and the server initiating an HTTP connection closing.
@theguild-bot theguild-bot mentioned this issue Jul 14, 2022
Closed
@ardatan
Copy link
Collaborator

ardatan commented Jul 23, 2022

We actually have that;
https://github.com/ardatan/graphql-tools/blob/master/packages/loaders/url/src/event-stream/handleReadableStream.ts#L25

@ardatan
Copy link
Collaborator

ardatan commented Jul 24, 2022

Also I don't think we need an EventSource implementation but we can have a recipe with Fetch API because I think it is simple enough to work with ReadableStreams

@ardatan ardatan closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@n1ru4l @ardatan