Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using graphql-js executor in favor of our own custom executor #1352

Closed
Tracked by #1358
Urigo opened this issue Jul 6, 2022 · 0 comments
Closed
Tracked by #1358

Stop using graphql-js executor in favor of our own custom executor #1352

Urigo opened this issue Jul 6, 2022 · 0 comments
Assignees
Milestone

Comments

@Urigo
Copy link
Collaborator

Urigo commented Jul 6, 2022

  1. Benefits
    • support new stuff like defer and stream
      • @defer and @stream support out of the box
        • No need to mess with graphql-js dependency
        • Docs and examples
    • support new stuff like oneOf
    • improve an algorithm to make it faster
    • introspection flags e.g. allow exporting directives via introspection
  2. Drawbacks
    • We can't support new language syntax features (we can keep track of their progress)
    • increased bundle size if we add new features that people wont use (defer/stream, oneOf)

Planned Tasks

  1. Start with a draft PR to remove default execute/subscribe in envelop/core and set those in a separate useSchema plugin (in envelop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants