Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL theme should respect prefers-color-scheme #1072

Closed
Tracked by #1358
freddydumont opened this issue Apr 10, 2022 · 1 comment
Closed
Tracked by #1358

GraphiQL theme should respect prefers-color-scheme #1072

freddydumont opened this issue Apr 10, 2022 · 1 comment
Milestone

Comments

@freddydumont
Copy link

Is your feature request related to a problem? Please describe.

The GraphiQL dark mode is hard coded. The contrast it creates with tabs and apps respecting the system color scheme makes it difficult to use.

I do understand the motivation for applying a dark mode to GraphiQL, as it can be blinding at night. However, it should be conditional on user preference.

Describe the solution you'd like

It should depend on prefers-color-scheme.

Describe alternatives you've considered

Browser extensions like Dark Reader work well to apply a dark mode over a light theme when system dark mode is turned on, but the use case to apply a light theme over dark mode when system dark mode is off isn't really supported.

Additional context

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

@Urigo Urigo added this to the v3.x milestone Jul 6, 2022
@theguild-bot theguild-bot mentioned this issue Jul 6, 2022
@enisdenjo
Copy link
Collaborator

GraphiQL shipping with Yoga v3 now respects the system preferred color scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants