Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e testing: fix AWS lambda deployment issues #1016

Closed
Tracked by #1358
dotansimha opened this issue Mar 29, 2022 · 0 comments
Closed
Tracked by #1358

e2e testing: fix AWS lambda deployment issues #1016

dotansimha opened this issue Mar 29, 2022 · 0 comments
Milestone

Comments

@dotansimha
Copy link
Owner

we are deploying AWS API Gateway (https://github.com/dotansimha/graphql-yoga/blob/master/e2e/tests/aws-lambda.ts#L100-L101) using REST configuration, and it seems like GraphiQL is not working with that setup. I think because API Gateway with REST config doesn't support HTML-related headers (because, well, it's for API calls... not static assets)

We can use API Gateway config based on raw HTTP instead of REST to address that.

@Urigo Urigo added this to the v3 milestone Jul 6, 2022
@theguild-bot theguild-bot mentioned this issue Jul 6, 2022
@ardatan ardatan closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants