Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ko: Translated into Korean. #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ko: Translated into Korean. #476

wants to merge 1 commit into from

Conversation

Hikai
Copy link

@Hikai Hikai commented Sep 22, 2020 •
edited
Loading

According to #102, Korean translation began in September 2017, but it was not completed for about three years until September 2020.
Newly translated and put a pull request. Please merge after the review.

@Hikai Hikai mentioned this pull request Sep 22, 2020
Open
@Hikai
Copy link
Author

Hikai commented Jul 19, 2021

@donnemartin How many reviewers do need?

mode9
mode9 approved these changes Dec 28, 2021
View reviewed changes
Copy link

@mode9 mode9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@roeniss
Copy link

roeniss commented Jan 20, 2022

@Hikai According to contirubtion guide and translation guide, it seems that you need to get reviews by Korean Translation maintainers.

Hi, @bonomoon and @mingrammer. Can you review this full translation, please?

@OsoriAndOmori
Copy link

It looks good to me. thanks 👍

@bonomoon
Copy link

@roeniss Sorry for my late reply. I have all reviewed. Thanks to @Hikai

@roeniss
Copy link

roeniss commented Apr 16, 2022

Hi @donnemartin, are you in charge of the merge? I think it's ready.

@bossm0n5t3r
Copy link

bossm0n5t3r commented May 5, 2022 •
edited
Loading

Please merge this PR. I really really want to read this. @donnemartin

@Hikai
Copy link
Author

Hikai commented May 9, 2022

2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out.

However, due to the lack of time due to the main job, the estimated time required is unknown.

I would appreciate it if other Koreans who participate in the PR. :)

@KKimj
Copy link

KKimj commented Jul 12, 2022 •
edited
Loading

@Hikai
Thanks!

@eomiso
Copy link

eomiso commented May 19, 2023

2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out.

However, due to the lack of time due to the main job, the estimated time required is unknown.

I would appreciate it if other Koreans who participate in the PR. :)

@Hikai Why is this PR still open? Do you need a hand in getting this PR merged?

@Hikai
Copy link
Author

Hikai commented May 24, 2023

2 years have passed since this document was translated, the correct expression and additional document translation work will be carried out.
However, due to the lack of time due to the main job, the estimated time required is unknown.
I would appreciate it if other Koreans who participate in the PR. :)

@Hikai Why is this PR still open? Do you need a hand in getting this PR merged?

@eomiso
I don't know what things I needs.
I want to merge this PR but maintainer seems busy. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korkt-kim korkt-kim korkt-kim approved these changes

@andrewchoi5 andrewchoi5 andrewchoi5 approved these changes

@mode9 mode9 mode9 approved these changes

Assignees
No one assigned
Labels
help wanted needs-review translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.