Avoid boxing if property is correct type.

For typed bindings, we'll have an `AvaloniaPropertyChangedEventArgs<T>` where `T` is the same as the type of the `AvaloniaPropertyObservable`. For non-typed bindings we'll have `object` as `T` so use the non-typed `AvaloniaProperty`.
donandren · Jan 20, 2020 · c2d5f62 · c2d5f62
1 parent 1ff6e35
commit c2d5f62
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/Avalonia.Base/Reactive/AvaloniaPropertyObservable.cs b/src/Avalonia.Base/Reactive/AvaloniaPropertyObservable.cs
@@ -44,7 +44,16 @@ private void PropertyChanged(object sender, AvaloniaPropertyChangedEventArgs e)
         {
             if (e.Property == _property)
             {
-                var newValue = e.Sender.GetValue(e.Property);
+                T newValue;
+
+                if (e is AvaloniaPropertyChangedEventArgs<T> typed)
+                {
+                    newValue = typed.Sender.GetValue(typed.Property);
+                }
+                else
+                {
+                    newValue = (T)e.Sender.GetValue(e.Property);
+                }
 
                 if (!Equals(newValue, _value))
                 {