Add methods for dispatching exceptions on osx.

donandren · Jan 19, 2020 · 69c0521 · 69c0521
1 parent c357558
commit 69c0521
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/Avalonia.Native/CallbackBase.cs b/src/Avalonia.Native/CallbackBase.cs
@@ -80,9 +80,11 @@ protected virtual void Destroyed()
 
         public void RaiseException(Exception e)
         {
-            var exceptionInfo = ExceptionDispatchInfo.Capture(e);
+            var threadingInterface = AvaloniaLocator.Current.GetService<PlatformThreadingInterface>();
 
-            PlatformThreadingInterface.s_exceptionDispatchInfo = exceptionInfo;
+            threadingInterface.TerminateNativeApp();
+
+            threadingInterface.DispatchException(ExceptionDispatchInfo.Capture(e));
         }
     }
 }
diff --git a/src/Avalonia.Native/PlatformThreadingInterface.cs b/src/Avalonia.Native/PlatformThreadingInterface.cs
@@ -13,8 +13,6 @@ namespace Avalonia.Native
 {
     public class PlatformThreadingInterface : IPlatformThreadingInterface
     {
-        public static ExceptionDispatchInfo s_exceptionDispatchInfo;
-
         class TimerCallback : CallbackBase, IAvnActionCallback
         {
             readonly Action _tick;
@@ -46,6 +44,7 @@ public void Signaled(int priority, bool priorityContainsMeaningfulValue)
         }
 
         readonly IAvnPlatformThreadingInterface _native;
+        private ExceptionDispatchInfo _exceptionDispatchInfo;
 
         public PlatformThreadingInterface(IAvnPlatformThreadingInterface native)
         {
@@ -86,15 +85,23 @@ public void RunLoop(CancellationToken cancellationToken)
                     }
                 }
 
-                if(s_exceptionDispatchInfo != null)
+                if(_exceptionDispatchInfo != null)
                 {
-                    // TODO terminate NSApp.
-
-                    s_exceptionDispatchInfo.Throw();
+                    _exceptionDispatchInfo.Throw();
                 }
             }
         }
 
+        public void DispatchException (ExceptionDispatchInfo exceptionInfo)
+        {
+            _exceptionDispatchInfo = exceptionInfo;
+        }
+
+        public void TerminateNativeApp()
+        {
+
+        }
+
         public void Signal(DispatcherPriority priority)
         {
             _native.Signal((int)priority);