Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide corner buttons and text #6

Open
jeffersonlam opened this issue Sep 27, 2016 · 3 comments
Open

Option to hide corner buttons and text #6

jeffersonlam opened this issue Sep 27, 2016 · 3 comments

Comments

@jeffersonlam
Copy link

jeffersonlam commented Sep 27, 2016

Hi, just found your plugin through this reddit thread here and I absolutely love it. Thank you for making this!

One thought I had was that it'd be awesome to be able to toggle the visibility of the options in the corner. It mucks up the visuals a bit and removes the "magic" (if you will) behind the serenity of seeing the image alone. The options are already accessible through the in-chrome menu via the extension icons. Having an option to hide that text would be awesome.

screen shot 2016-09-27 at 4 09 53 pm

@domoritz
Copy link
Owner

Awesome. The controls in the bottom left are usually very dim and only appear when you move your cursor. I can see how this can still remove some of the magic.

it should be trivial to add an option to hide the controls entirely. Do you want to send a pr?

@jeffersonlam
Copy link
Author

I'm unfamiliar with how chrome extensions work, but I can take a shot at it. Could you point me in a direction?

@domoritz
Copy link
Owner

domoritz commented Sep 29, 2016

It's a simple website with one additional file for options https://github.com/domoritz/himawari-8-chrome/blob/gh-pages/options.html and some code to read options https://github.com/domoritz/himawari-8-chrome/blob/gh-pages/src/main.js#L358.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants