Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tolerance for version upgrades in config file #3

Open
blimmer opened this issue Apr 5, 2018 · 1 comment
Open

Introduce tolerance for version upgrades in config file #3

blimmer opened this issue Apr 5, 2018 · 1 comment

Comments

@blimmer
Copy link

blimmer commented Apr 5, 2018

We just upgraded from Rails 5.0.6 to the newly released 5.0.7 and suddenly all of our existing safelisted entries started failing. After taking a look at it, we saw that the version incremented in the deprecation callstack message. Here's the diff that fixed the problem:

-    not deprecated: http://api.rubyonrails.org/v5.0.6/classes/ActionController/Parameters.html'
+    not deprecated: http://api.rubyonrails.org/v5.0.7/classes/ActionController/Parameters.html'

What do you think about adding some kind of tolerance for that version number to make bugfix upgrades easier?

I'd be willing to make a PR for something like this if it aligns with you!

@domcleal
Copy link
Owner

Sorry for the delay - this sounds like a good idea, I'd be happy to accept such a feature!

I did add support for matching prefixes only for a similar reason, if I remember correctly. It meant I could leave out some of the overly specific URLs etc. from messages if needed, this might be a useful workaround for you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants