Remove insecure CollectionPresenter default add item prompt (uses compiler) #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests, e.g. DisplayMonitor>>testActive, will fail if Dolphin is not the foreground process, because when not the foreground process one cannot control the active window. This is annoying if running tests while using the machine to do something else, so better to skip them.
…piler) Use of the compiler in an application is obviously insecure. In order to be secure by default this has to be removed, even though a breaking change. Also add back CollectionPresenter up/down/first/last icons to dev res as the TextTileIcons come up too small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the compiler in an application to translate user input is obviously insecure. In order to be secure by default this has to be removed, even though a breaking change.
Also add back
CollectionPresenterup/down/first/last icons to dev res as theTextTileIconscome up too small.