feat(build): load passed in config option #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
feat/more-opts
branch
from
eda4469
to
95435a7
Compare
|
👍 Thanks for the PR! Could you try removing the config parser from shared_options so that we don't have two code paths that do config loading? We'd keep the |
|
@tmcw done |
|
Awesome - thanks, merging! |
|
Cool, any chance you could do a release of documentation + gulp-documentation soon? Thanks |
|
Yep, definitely. Was hoping to do this today but it's on my todo list for when I get home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes documentationjs/gulp-documentation#27