Skip to content

Commit

Permalink
Reference the right argument
Browse files Browse the repository at this point in the history
This deprecation references an argument that does not exist.
  • Loading branch information
greg0ire committed May 31, 2023
1 parent 4d27b98 commit 9ccd199
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,9 @@ if (! $diff->isEmpty()) {
}
```

## Deprecated not passing `$fromColumn` to the `TableDiff` constructor.
## Deprecated not passing `$fromTable` to the `TableDiff` constructor.

Not passing `$fromColumn` to the `TableDiff` constructor has been deprecated.
Not passing `$fromTable` to the `TableDiff` constructor has been deprecated.

The `TableDiff::$name` property and the `TableDiff::getName()` method have been deprecated as well. In order to obtain
the name of the table that the diff describes, use `TableDiff::getOldTable()`.
Expand Down Expand Up @@ -1002,7 +1002,7 @@ deprecated in order to provide a more consistent API.

## Deprecated `Comparator::compare($fromSchema, $toSchema)`

The usage of `Comparator::compare($fromSchema, $toSchema)` is deprecated and
The usage of `Comparator::compare($fromSchema, $toSchema)` is deprecated and
replaced by `Comparator::compareSchemas($fromSchema, $toSchema)` in order to
clarify the purpose of the method.

Expand Down
2 changes: 1 addition & 1 deletion src/Schema/TableDiff.php
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public function __construct(
Deprecation::trigger(
'doctrine/dbal',
'https://github.com/doctrine/dbal/pull/5678',
'Not passing the $fromColumn to %s is deprecated.',
'Not passing the $fromTable to %s is deprecated.',
__METHOD__,
);
}
Expand Down

0 comments on commit 9ccd199

Please sign in to comment.