Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vue Reactivity #1271

Merged
merged 11 commits into from
Oct 8, 2020
Merged

Fix Vue Reactivity #1271

merged 11 commits into from
Oct 8, 2020

Conversation

jhildenbiddle
Copy link
Member

@jhildenbiddle jhildenbiddle commented Jul 5, 2020 •
edited
Loading

Fixes #788 #790 #1074 #1252 #1364

  • Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2) skipping elements that are already Vue instances
  • Retain previous behavior of handling basic Vue rendering without the need for a markdown <script> tag.
  • Add Vue3 support
  • Update documentation and add live Vue examples
  • Update index.html files to include Vue.js
  • Update Cypress Jest+Playwright e2e tests

Summary: Docsify was mounting #main as a Vue component on every page change when it detected Vue.js, presumably to process basic Vue content without requiring a <script> tag in each markdown file. The issue is that this was happening after users had already instantiated child elements of #main as Vue components, destroying those instances.

@jhildenbiddle
Fix Vue compatibility (fix #790)
f385e21 
- Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2)  skipping elements that are already Vue instances
- Retain previous behavior of processing basic Vue rendering without the need for a markdown <script> tag.
- Update documentation and add live Vue examples
- Update `index.html` files to include Vue.js and Vuep (CSS+JS)
@jhildenbiddle
Merge branch 'develop' into fix-790
aa1d1e6 
# Conflicts:
#	docs/index.html
@vercel
Copy link

vercel bot commented Jul 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/gw3jsrcph
✅ Preview: https://docsify-preview-git-fix-790.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 5, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f6148d:

Sandbox Source
docsify-template Configuration

anikethsaha
anikethsaha approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome

@jhildenbiddle jhildenbiddle self-assigned this Jul 5, 2020
Koooooo-7
Koooooo-7 previously approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! 👍

anikethsaha
anikethsaha previously approved these changes Jul 5, 2020
View reviewed changes
sy-records
sy-records previously approved these changes Jul 5, 2020
View reviewed changes
trusktr
trusktr previously requested changes Jul 5, 2020
View reviewed changes
Copy link
Member

@trusktr trusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, but let's add unit tests.

docs/index.html Outdated Show resolved Hide resolved
src/core/render/index.js Show resolved Hide resolved
@anikethsaha
Copy link
Member

This is a good change, but let's add unit tests.

tests fixtures (e2e-cypress) have been updated. But yea unit/integration tests would be great to add. But is it possible to do unit testing for this change ? if so, it would be great to add.

trusktr
trusktr reviewed Jul 5, 2020
View reviewed changes
src/core/render/index.js Outdated Show resolved Hide resolved
trusktr
trusktr reviewed Jul 5, 2020
View reviewed changes
src/core/render/index.js Outdated Show resolved Hide resolved
@jhildenbiddle jhildenbiddle mentioned this pull request Jul 5, 2020
Closed
1 task
@jhildenbiddle jhildenbiddle linked an issue Jul 5, 2020 that may be closed by this pull request
Dynamic content in Vue components #1074
Closed
1 task
@jhildenbiddle
Updates per request
105fbbf 
- When Vue.js is detected, markdown `<script>` is not executed when executeScript is `false` (matches previous behavior)
- Minor code tweaks that do not affect functonality
@jhildenbiddle jhildenbiddle mentioned this pull request Jul 8, 2020
Merged
18 tasks
@jhildenbiddle jhildenbiddle added the vuejs related to Vue.js label Jul 8, 2020
anikethsaha
anikethsaha previously approved these changes Oct 7, 2020
View reviewed changes
@jhildenbiddle jhildenbiddle dismissed trusktr’s stale review October 7, 2020 20:48

Outdated / Issues Resolved

This was referenced Oct 7, 2020
Closed
Closed
Closed
@jhildenbiddle jhildenbiddle linked an issue Oct 8, 2020 that may be closed by this pull request
How to create global vue variables in html and make it readable on .md files? #1252
Closed
This was linked to issues Oct 8, 2020
Vue not working with reactivity #790
Closed
Support Vue3 #1364
Closed
@jhildenbiddle jhildenbiddle merged commit 761210c into develop Oct 8, 2020
This was referenced Oct 8, 2020
Closed
Closed
@jhildenbiddle jhildenbiddle deleted the fix-790 branch October 8, 2020 22:07
@sy-records sy-records mentioned this pull request Feb 5, 2021
Merged
3 tasks
This was referenced Mar 9, 2021
Merged
Open
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikethsaha anikethsaha anikethsaha approved these changes

@sy-records sy-records sy-records approved these changes

@trusktr trusktr Awaiting requested review from trusktr

@Koooooo-7 Koooooo-7 Awaiting requested review from Koooooo-7

Assignees

@jhildenbiddle jhildenbiddle

Labels
vuejs related to Vue.js
Projects
None yet
Milestone
No milestone
5 participants
@jhildenbiddle @anikethsaha @trusktr @Koooooo-7 @sy-records