Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant instruction from lint-staged config #1108

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Apr 9, 2020

Summary
Bump lint-staged dep. Since v10 modified files are automatically added to the git commit index.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: bump dependency

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

N/A

  • DO NOT include files inside lib directory.

package.json Show resolved Hide resolved
@anikethsaha anikethsaha requested review from a team, trusktr and Koooooo-7 and removed request for a team April 9, 2020 05:24
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to lint-staged documentation they will automatically add to git index since version 10, it's okay to upgrade.

I suggest we'd better to wait and see the latest version for a while.
I prefer to use a steady version now.

@stale
Copy link

stale bot commented Jun 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 8, 2020
@vercel
Copy link

vercel bot commented Jun 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/bteo8jt0e
✅ Preview: https://docsify-preview-git-fork-jamesgeorge007-update-config.docsify-core.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9d3251:

Sandbox Source
peaceful-cannon-rjjkl Configuration

Copy link
Member

@trusktr trusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the new lint-staged for a while in my projects. It works very well. The author of that library is very responsive and fixes all issues immediately, and does a very good job with it.

@trusktr
Copy link
Member

trusktr commented Jun 10, 2020

This doesn't affect end users. I say let's merge it. It works well. I was bothered by the left-over modifications after each commit.

@trusktr
Copy link
Member

trusktr commented Jun 10, 2020

Thanks @jamesgeorge007 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants