Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadSidebar: true doesn't work well when script src doesn't contain docsify. #860

Closed
1 task done
L3au opened this issue Jun 3, 2019 · 3 comments · Fixed by #861
Closed
1 task done

loadSidebar: true doesn't work well when script src doesn't contain docsify. #860

L3au opened this issue Jun 3, 2019 · 3 comments · Fixed by #861

Comments

@L3au
Copy link
Contributor

L3au commented Jun 3, 2019

Bug Report

Steps to reproduce

I create a bug showcase as below to reproduce this.

https://l3au.github.io/assets/docsify/

What is current behavior

loadSidebar: true config doesn't work

What is the expected behavior

Make it work even when the script url doesn't contain docsify. by the following ways

  • fix document.currentScript using
  • improve config fields coercion

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: macOS Mojave 10.14.5

  • Node.js version: v10.15.3

  • npm/yarn version: npm 6.4.1

  • Browser version: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

  • Docsify version: 4.9.4

  • Docsify plugins: none

@ddzy
Copy link

ddzy commented Jun 26, 2019

same problem

@L3au
Copy link
Contributor Author

L3au commented Jun 28, 2019

@timaschew @QingWei-Li
Hi guys, would you be available to review this problem, I have given a solution to this issue #861.

Thanks for the consideration. Please let me know if you have any other questions.

@methodbox
Copy link

This actually doesn't work at all.

using:

window.$docsify = {
        name: "",
        repo: "",
        loadSidebar: "summary.md"
      };

...simply does nothing. Even setting it to false doesn't get rid of the sidebar. Kind of sad that the owner doesn't seem to care because this renders their project useless since you can't even get rid of the useless sidebar.

Lame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants