Forcing a nil IP specified in PortBindings to IPv4zero (0.0.0.0). #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 21, 2019
full diff: moby/libnetwork@9ff9b57...5ac07ab brings in: - moby/libnetwork#2376 Forcing a nil IP specified in PortBindings to IPv4zero (0.0.0.0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
May 21, 2019
full diff: moby/libnetwork@9ff9b57...5ac07ab brings in: - moby/libnetwork#2376 Forcing a nil IP specified in PortBindings to IPv4zero (0.0.0.0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a66ddd8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 23, 2019
full diff: moby/libnetwork@9ff9b57...5ac07ab brings in: - moby/libnetwork#2376 Forcing a nil IP specified in PortBindings to IPv4zero (0.0.0.0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a66ddd8ab88f63af646c01fc84d2ffcc2b0c240f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 939aa52465212e5ade5eeed7dffa4cd48b17816d Component: engine
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 23, 2019
full diff: moby/libnetwork@9ff9b57...5ac07ab brings in: - moby/libnetwork#2376 Forcing a nil IP specified in PortBindings to IPv4zero (0.0.0.0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: a66ddd8ab88f63af646c01fc84d2ffcc2b0c240f Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a different key for the port mapper.
During AllocatePorts, the portbindings hostIP was nil. So, the key to the port mapper was <HostIP:nil, host port, etc...>
However, during ReleasePorts, the portbindings hostIP was 0.0.0.0. So, the key to port mapper was <HostIP:0.0.0.0, host port, etc...>
Since thoe HostIP was different (nil vs 0.0.0.0), we never removed the entry from the port mapper. This resulted in us leaking all the port bindings in port mapper.
Signed-off-by: Pradip Dhara pradipd@microsoft.com