Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] rootless: fix proxying UDP packets #434

Merged
merged 1 commit into from
Jan 20, 2020
Merged

[19.03 backport] rootless: fix proxying UDP packets #434

merged 1 commit into from
Jan 20, 2020

Conversation

AkihiroSuda
Copy link

backport moby#40317

@AkihiroSuda
Copy link
Author

CI failure seems unrelated

[2019-12-31T07:24:04.578Z] + bundleName=amd64

[2019-12-31T07:24:04.578Z] + echo Creating amd64-bundles.tar.gz

[2019-12-31T07:24:04.578Z] Creating amd64-bundles.tar.gz

[2019-12-31T07:24:04.578Z] + xargs tar -czf amd64-bundles.tar.gz

[2019-12-31T07:24:04.578Z] + find bundles -path */root/*overlay2 -prune -o -type f ( -name *-report.json -o -name *.log -o -name *.prof -o -name *-report.xml ) -print

[2019-12-31T07:24:04.578Z] find: ‘bundles’: No such file or directory

[2019-12-31T07:24:04.578Z] tar: Cowardly refusing to create an empty archive

[2019-12-31T07:24:04.578Z] Try 'tar --help' or 'tar --usage' for more information.

script returned exit code 123

@thaJeztah thaJeztah added this to the 19.03.6 milestone Jan 6, 2020
thaJeztah
thaJeztah approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Jan 16, 2020
View reviewed changes
Copy link

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@AkihiroSuda can you rebase this one? docker-py tests should be fixed in this branch: we can merge after that

@thaJeztah
Copy link
Member

triggered CI - I think it actually does a merge before running, so perhaps rebase is not needed. Fingers crossed

@AkihiroSuda
rootless: fix proxying UDP packets
325e889 
UDP reply packets were not proxied: rootless-containers/rootlesskit#86

The issue was fixed in RootlessKit v0.7.1: rootless-containers/rootlesskit#87

Full changes since v0.7.0: rootless-containers/rootlesskit@v0.7.0...v0.7.1

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 658723b)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Author

rebased

@thaJeztah
Copy link
Member

all green now; merging 👍

@thaJeztah thaJeztah merged commit ec50d8f into docker-archive:19.03 Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
19.03.6
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @thaJeztah @cpuguy83