This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] builder entitlements configuration added. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildkit supports entitlements like network-host and security-insecure. this patch aims to make it configurable through daemon.json file. by default network-host is enabled & secuirty-insecure is disabled. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com> (cherry picked from commit 8b7bbf1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
|
ping @tonistiigi @tiborvass PTAL - I think you mentioned this should be in 19.03 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#39144
relates to:
buildkit supports entitlements like network-host and security-insecure.
this patch aims to make it configurable through daemon.json file.
by default network-host is enabled & security-insecure is disabled.
- What I did
option to enable/disable buildkit's entitlements settings for moby
fixes part of issue discussed here moby/buildkit#950 (comment)
- How I did it
Added
entitlementsin builder config- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)