Fixes #2543: bug with panic when DOCKER_CLI_EXPERIMENTAL is incorrect #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is incorrect Signed-off-by: Daniil Nikolenko <qoo2p5@gmail.com>
|
@tiborvass @silvin-lubecki PTAL (need to check if this affects the 19.03 branch as well) |
tiborvass
approved these changes
May 28, 2020
|
This does affect 19.03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I've fixed the bug described in #2543.
- How I did it
panic(err)in the place which caused panic before. It will help to find similar problems easier in the future.- How to verify it
The steps are described in the issue. You can see that after my commit everything works as expected.
- Description for the changelog
Fixed bug with panic when DOCKER_CLI_EXPERIMENTAL is set to incorrect value.