Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03 backport] vendor: k8s.io/klog v1.0.0-2-g4ad0115 #2516

Merged
merged 1 commit into from
May 11, 2020

Conversation

thaJeztah
Copy link
Member

backport of #2515 for 19.03

NOTE cherry-pick was not clean, because 19.03 uses older versions of kubernetes. I resolved the conflict in vendor.conf, and re-vendored the dependency.

Temporarily vendoring tip of the release-1.x branch, to address docker context inspect being slow on Windows because this package performs user lookup through os.Current() during init().

fixes #2420

- Description for the changelog

Fix `docker context inspect` being slow on Windows

Temporarily vendoring tip of the release-1.x branch, to address
docker context inspect being slow on Windows because this package
performs user lookup through `os.Current()` during `init()`.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 466c50f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

opening as draft, pending #2515 to be merged

@thaJeztah
Copy link
Member Author

ping @silvin-lubecki @simonferquel PTAL

@simonferquel
Copy link
Contributor

sgtm

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah marked this pull request as ready for review May 11, 2020 12:42
@silvin-lubecki silvin-lubecki merged commit a9a83d2 into docker:19.03 May 11, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_bump_klog branch May 11, 2020 14:22
@grahamehorner
Copy link

@thaJeztah any idea on a release, this seems to be the fix for what is causing frustration when I'm out of the office and logged into a domain account with internet connection; every docker is taking an again. but logged in as a local (non-domain) account is ok

@thaJeztah
Copy link
Member Author

@grahamehorner this is included in the 19.03.9 release. Not sure when Docker Desktop is updated to include that version though; let me ask if there's an ETA

@grahamehorner
Copy link

@thaJeztah many thanks

@thaJeztah
Copy link
Member Author

I was informed that the next Docker Desktop release on the "edge" channel will be end of this month, and "stable" channel is released every three months.

That's for "regular" / "scheduled" releases, so it's possible that a patch release in either channel is done before that, which may include the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants