context: produce consistent output on context create.
#1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter is complaining |
ijc
force-pushed
the
consistent-output-on-context-create
branch
from
24b6c8a
to
bd7882e
Compare
|
Oops, I got distracted right at the point I was supposed to write that comment. Now done. |
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 56.74% 56.76% +0.01%
==========================================
Files 309 309
Lines 21676 21676
==========================================
+ Hits 12301 12305 +4
+ Misses 8476 8472 -4
Partials 899 899 |
Refactor `RunCreate` slightly so that all three paths always produce the same output, namely the name of the new context of `stdout` (for scripting) and the success log message on `stderr`. Validate by extending the existing unit tests to always check the output is as expected. Signed-off-by: Ian Campbell <ijc@docker.com>
ijc
force-pushed
the
consistent-output-on-context-create
branch
from
bd7882e
to
ff44305
Compare
thaJeztah
added
area/context
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
RunCreateslightly so that all three paths always produce the sameoutput, namely the name of the new context of
stdout(for scripting) and thesuccess log message on
stderr.Validate by extending the existing unit tests to always check the output is as
expected.
Signed-off-by: Ian Campbell ijc@docker.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)