Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle a Docker daemon without registry info #126

Merged

Commits on May 26, 2017

  1. Handle a Docker daemon without registry info

    The current implementation of the ElectAuthServer doesn't handle well when the
    default Registry server is not included in the response from the daemon Info
    endpoint.
    
    That leads to the storage and usage of the credentials for the default registry
    (`https://index.docker.io/v1/`) under an empty string on the client config file.
    
    Sample config file after a login via a Docker Daemon without Registry
    information:
    ```json
    {
    	"auths": {
    		"": {
    			"auth": "***"
    		}
    	}
    }
    ```
    
    That can lead to duplication of the password for the default registry and
    authentication failures against the default registry if a pull/push is performed
    without first authenticating via the misbehaving daemon.
    
    Also, changes the output of the warning message from stdout to sdterr as
    per dnephin suggestion.
    
    Signed-off-by: Marcus Martins <marcus@docker.com>
    marcusmartins committed May 26, 2017
    Configuration menu
    Copy the full SHA
    8626497 View commit details
    Browse the repository at this point in the history