Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [dask] make Dask distributed example copy-pastable #6345

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[docs] [dask] make Dask distributed example copy-pastable #6345

merged 1 commit into from
Nov 12, 2020

Conversation

jameslamb
Copy link
Contributor

Hello! I've been getting more familiar with the XGBoost Dask interface, as part of dask/community#104. I was working through the documentation at https://xgboost.readthedocs.io/en/latest/tutorials/dask.html#overview tonight, and I'd like to suggest an improvement to them.

This PR proposes adding some Dask Array code to generate random data, instead of relying on users to figure that out themselves based on a code comment. I think making the examples easy to run by just copying and pasting will make it easier for users to start experimenting with xgboost.dask.

This also proposes adding links to the Dask DataFrame and Dask Array documentation, to help users who might not be familiar with those collections.

Thanks for your time and consideration.

Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for taking interest in XGBoost Dask API.

@hcho3 hcho3 merged commit 12d27f4 into dmlc:master Nov 12, 2020
@jameslamb jameslamb deleted the docs/dask-examples branch November 12, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants