Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DATASET] add LCQMC, ChnSentiCorp dataset #774

Merged
merged 6 commits into from
Jun 24, 2019

Conversation

paperplanet
Copy link
Member

@paperplanet paperplanet commented Jun 16, 2019

Description

add LCQMC, ChnSentiCorp dataset

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@paperplanet paperplanet requested a review from szha as a code owner June 16, 2019 16:31
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

❗ No coverage uploaded for pull request head (feature/add-baidu-ernie-dataset@e9037cb). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #774 into master will increase coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   90.21%   91.09%   +0.88%     
==========================================
  Files          64       64              
  Lines        6233     6469     +236     
==========================================
+ Hits         5623     5893     +270     
+ Misses        610      576      -34
Impacted Files Coverage Δ
src/gluonnlp/utils/parameter.py 81.81% <0%> (-3.37%) ⬇️
src/gluonnlp/model/bilm_encoder.py 100% <0%> (ø) ⬆️
src/gluonnlp/data/glue.py 99.27% <0%> (+0.48%) ⬆️
src/gluonnlp/data/stream.py 89.61% <0%> (+0.54%) ⬆️
src/gluonnlp/data/word_embedding_evaluation.py 96.96% <0%> (+0.75%) ⬆️
src/gluonnlp/model/utils.py 77.58% <0%> (+0.86%) ⬆️
src/gluonnlp/data/batchify/batchify.py 96.29% <0%> (+1.23%) ⬆️
src/gluonnlp/data/dataset.py 98.41% <0%> (+1.58%) ⬆️
src/gluonnlp/data/utils.py 76.19% <0%> (+2.04%) ⬆️
src/gluonnlp/data/corpora/wikitext.py 100% <0%> (+5.17%) ⬆️
... and 3 more

@mli
Copy link
Member

mli commented Jun 16, 2019

Job PR-774/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-774/1/index.html

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What are the licenses of these datasets? Could you add them to the classes?
If the dataset licenses are friendly, we can consider redistributing them.

@paperplanet
Copy link
Member Author

Thanks! What are the licenses of these datasets? Could you add them to the classes?
If the dataset licenses are friendly, we can consider redistributing them.

OK, I can add the license for LCQMC and XNLI.
LCQMC is licensed under a Creative Commons Attribution 4.0 International License. License details: http://creativecommons.org/licenses/by/4.0/. XNLI has Attribution-NonCommercial 4.0 International
license : https://github.com/facebookresearch/XNLI/blob/master/LICENSE, (https://creativecommons.org/licenses/by-nc/4.0/). But I can't find ChnSentiCorp's license. All these dataset are redistributed by baidu. Seems we can at least redistribute XNLI and LCQMC.

@szha
Copy link
Member

szha commented Jun 18, 2019

We probably can't redistribute XNLI due to the non-commercial license.

@mli
Copy link
Member

mli commented Jun 18, 2019

Job PR-774/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-774/2/index.html

@mli
Copy link
Member

mli commented Jun 18, 2019

Job PR-774/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-774/3/index.html

@paperplanet
Copy link
Member Author

We probably can't redistribute XNLI due to the non-commercial license.

Oh. What a pity.

@eric-haibin-lin
Copy link
Member

We probably can't redistribute XNLI due to the non-commercial license.

It only means that we cannot host the dataset, right? Using external links is fine?

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix the lint failure ?

@szha
Copy link
Member

szha commented Jun 22, 2019

It only means that we cannot host the dataset, right? Using external links is fine?

yes that's what I meant

@mli
Copy link
Member

mli commented Jun 23, 2019

Job PR-774/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-774/4/index.html

@mli
Copy link
Member

mli commented Jun 24, 2019

Job PR-774/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-774/5/index.html

@mli
Copy link
Member

mli commented Jun 24, 2019

Job PR-774/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-774/6/index.html

@szha szha merged commit 6c2450b into dmlc:master Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants